Hey all, I need some help.

I wrote a simple powershell to add/remove a user in local groups. I'm giving this to other techs in the area to use as well so I included a simple error trap to let them know if an error occurred or not. Basically what I'm doing is I define a "count" variable = 0 and if it enters the trap, count increases by 1. Only problem is it runs the other commands in the trap, but never increases count? I'm a total noob when it comes to powershell so I figured I'd ask for help. Here's my code:

$Computers = Read-Host 'Please enter computer name'
$domain = Read-Host 'Please enter domain name'
$group = Read-Host 'Please enter group name (ie Administrators, Remote Desktop Users)'
$username = Read-Host 'Please enter username.'
$check = 0

foreach ($computer in $Computers) { 
   $addcomp = [ADSI]("WinNT://" + $computer + ",computer") 
   $group2 = $addcomp.psbase.children.find("$group") 
   $group2.Add("WinNT://" + $domain + "/" + $username)

trap [Exception] { 
$check++ 
$("ERROR on $computer " + $_.Exception.GetType().FullName) | Add-Content add-errors.txt
$("Message: " + $_.Exception.Message) | Add-Content add-errors.txt
continue; } }

if ($check -eq 0 ) {
Write-Host ("The command completed successfully $check") }
else {
Write-Host ("Errors were detected. See add-errors.txt") }

Check always stays at 0 but it writes the error file successfully. Thanks in advance for any help. Probably simple.

Change $check to $global:check

Also, you don't need to specify [Exception], since that is the base type of all exceptions. You only need to do this:

trap
{
   # trap stuff...
}

I just saw "global"... Be very careful with global because the check value will be set on a console basis, so each subsequent run of the script will continue to count up check until a new session/console is started.

$script:check may be more appropriate/less troublesome.

Jiffy: see:
PS> help about_scopes

Posted By marco.shaw on 26 Jul 2010 04:48 AM

$script:check may be more appropriate/less troublesome.

I second that. If you must use global, make sure that at the top of your script (or in a begin { ... } block) you reset it to zero ;-)