(Excuse me for being 2-3 years behind the PS curve :-) )
I'm trying to fix our missing UPNs.  I wrote this to locate them:

get-qaduser -includedproperties userprincipalname -SearchRoot "company.com/user accounts" -sizelimit 0|where {!($_.userprincipalname -like "*@*") }

Which works great.  Now I want to pipe the output to set-qaduser to populate the UPN by adding this to the above code:

|set-qaduser  -userprincipalname "$($_.samAccountName)@company.com"

No matter what I try $_.samaccountname is always null.  What am I missing?

\\Greg

The problem with your current script is that $_ doesn't have a value when you are trying to reference it. $_ only gets set inside script blocks in the pipeline like in ForEach-Object, Where-Object, or in Script Block parameters.

So you need to either do this:

... | Set-QADUser -UserPrincipalName {"$($_.samAccountName)@company.com"}

or this:

... | ForEach-Object {
$_ | Set-QADUser -UserPrincipalName "$($_.samAccountName)@company.com"
}

Thanks, Kirk. The first option didn't appear to work but the second did!

Thanks

\\Greg

You could try this--the ldap search should be a lot faster than the where filter:

get-qaduser -includedproperties userprincipalname,samaccountname -SearchRoot "company.com/user accounts" -ldapfilter '(!(userprincipalname=*@*))' -sizelimit 0 | %{$_.userprincipalname = "$($_.samaccountname)@company.com";$_.commitchanges()}

Leave off the pipe to the foreach script block to see what that returns. When you're comfortable with the results then add the pipe to the foreach script block to make the changes.

Cameron, this looks interesting. What type of object is being passed in $_? Is it an [ADSI] object that you are acting on directly instead of using Set-Qaduser?

\\Greg

It's passing a user object from the get-qaduser cmdlet. It will have available all default properties as well as properties specified by the -includedproperties parameter. For you to actually change the parameters you will need to run PowerShell from an administrators context (loging as admin or runas admin) or pass a PSCredential object with admin credentials to the cmdlet.

I'm not sure what the underlying technology Quest is relying on. It could be ADSI or most likely .Net object. [adsi] uses .setinfo the quest object has a .commitchanges() method so the underlying tech is hidden.