Hello

I have created a script and I wondered if anyone could suggest any improvements (not hard i'm sure).

Basically, all my AD accouts have either the type of accounts they are (System, Departmental etc...) or the users job title in the Title field. My script goes through AD and basicaly counts up how many there are of each account and then displays this to the screen.

The problem I am finding is that this takes up a massive amount of memory and my pc is not usable whilst PowerShell runs the script.

Any suggestion on how to improve this woud be most welcomed.

# Script to check for various types of accounts

$Departmental = get-qaduser -title Departmental -sizelimit 0
$Training = Get-QADUser -title Training -sizelimit 0
$System = Get-QADUser -title System -sizelimit 0
$Service = Get-QADUser -title Service -sizelimit 0
$Users = Get-QADUser -sizelimit 0 | where { $_.title -ne "Training" -AND "Departmental" -And "Service"}
$Total = Get-QADUser -Sizelimit 0

write-host "There are a total of" $Total.count "Accounts"
write-host "There are a total of" $Users.count "User Accounts"
write-host "There are a total of" $System.count "System Accounts"
write-host "There are a total of" $Departmental.count "Departmental Accounts"
write-host "There are a total of" $Service.count "Service Accounts"
write-host "There are a total of" $Training.count "Training Accounts"

Thanks

Lee 

Since I can't work on your AD ;-), here's an example using the file system:


PS > $acct = dir | group extension -NoElement
PS > $acct

Count Name
----- ----
74
138 .ps1
6 .vbs
1 .bat
3 .xml
8 .csv
2 .rar
2 .htm
1 .InstallLog
1 .JPG
1 .fdf
1 .wav
6 .txt
2 .cmd
1 .html
1 .config


Get total count:

PS > $total = $acct | measure-object -property count -sum
PS > $total.sum
248

This is the equivalent of:
# $Users = Get-QADUser -sizelimit 0 | where { $_.title -ne "Training" -AND "Departmental" -And "Service"}

#$acct | where { $_.name -ne ".txt" -and $_.name -ne ".cmd" -and $_.name -ne ".ps1" }
$acct | where { $_.name -notmatch "\.(txt|cmd|ps1)" }

Count Name
----- ----
   74
    6 .vbs
    1 .bat
    3 .xml
    8 .csv
    2 .rar
    2 .htm
    1 .InstallLog
    1 .JPG
    1 .fdf
    1 .wav
    1 .html
    1 .config

Makes sense?
 

Maybe this way. I would remove the select-object, adding -noElement to group-object leaves you with just the columns you're after. Notice the first foreach-object clause (begin), it defines a variable to hold the standard users count.


get-qaduser -searchroot $OU -sizelimit 0 | foreach {$leftOver=0} {
   if( $_.title -match "(service|training|system|departmental|Leaver)") {
      $_
   } else { 
      $leftOver++
   }
} | group title -noElement | ft -autosize

$leftOver



 

I'll try that.  What I came up with in the meantime which sort of works is:

$user = get-qaduser -sizelimit 0 | where { $_.title -notmatch "(Service|Training|System|Departmental|Leaver)"}; write-host "User Accounts:" $user.count; get-qaduser -sizelimit 0 | where { $_.title -match "(Service|Training|System|Departmental|Leaver)"} | group title | select Count,Name | ft -autosize

This works alot faster than what my origional script did but.......... if the user account has a title such as "Departmental Trainer"  it gets counted seperately.  I think its because of the -match operator but after trying the others such as -eq and -like nothing works. If i can get that ironed out then I'm basically there.