Hello

I've created a pretty basic script to go to a bunch of severs listed in a file (servers.txt) and report back to a csv file the disk size and freespace.  My problem is i'm very new to powershell and I am really struggling to get both the disk size AND the freespace converted to GB.  I can do one or the other but not both.

Any advice would be greatly appreciated.

Here's the script.

Gwmi win32_logicaldisk -Filter "DriveType=3" -comp (gc c:\servers.txt) | Select-Object -Property SystemName,Caption,VolumeName,Size,FreeSpace | ForEach-Object -Process {$_.FreeSpace = ($_.FreeSpace)/1024/1024/1024; $_} | format-table | out-file -filepath c:\Disk-GB.csv

 Many thanks

Lee

Try this:

Gwmi win32_logicaldisk -Filter "DriveType=3" -comp (gc c:\servers.txt) | Select-Object SystemName,Caption,VolumeName,@{Name="Size"; Expression={$_.Size/1GB}},@{Name="Freespace"; Expression={$_.Freespace/1GB}} | format-table | out-file -filepath c:\Disk-GB.csv

Thanks for help.

I can see the changes you have made but i'm not entirely sure how what the @ does in this instance. If it's no problem, could you explain how it fixes the script so i can learn my mistake.

Thanks

1. This below WMI query is processed on the client itself (aka server side processing) saving lots of network bandwidth and is much faster to execute in terms of script performance.

2. There is no need to format-table when you want to store the output in csv files, instead use the export-csv cmdlet.

PS > gwmi -query "SELECT SystemName,Caption,VolumeName FROM win32_logicaldisk WHERE DriveType=3" -computer (gc c:\servers.txt) | Select-Object SystemName,Caption,VolumeName,@{Name="Size"; Expression={$_.Size/1GB}},@{Name="Freespace"; Expression={$_.Freespace/1GB}} | export-csv -filepath c:\Disk-GB.csv

Thanks all for the help and suggestions.  The script is looking real good and i've added  | sort -prop Freespace | into the pipeline to get things in order.

One thing I want to add to the script to get it perfect is to get PowerShell to create a new field which is the freespace percentage.  Currently I do this by hand once its in the spreadsheet which works but isn't ideal.

Any ideas on this would be welcomed.

Thanks

Lee

You can use Add-Member to add that property and simple division of course to generate the value.

$freespace = $obj.diskUsage / $obj.diskCapacity
$obj | add-member -name FreeSpace -MemberType NoteProperty -Value $freespace

hmmm.

I seem to get stuck on this, I tried it a couple ways around but with no luck.

First this way:

$freespace = $obj.diskUsage / $obj.diskCapacity;
$obj | add-member -name FreeSpace -MemberType NoteProperty -Value $freespace;
Gwmi win32_logicaldisk -Filter "DriveType=3" -comp (gc c:\server.txt) | Select-Object SystemName,Caption,VolumeName,@{Name="Size"; Expression={$_.Size/1GB}},@{Name="Freespace"; Expression={$_.Freespace/1GB}} | sort -property Freespace | format-table

and then this way:

Gwmi win32_logicaldisk -Filter "DriveType=3" -comp (gc c:\server.txt) | Select-Object SystemName,Caption,VolumeName,@{Name="Size"; Expression={$_.Size/1GB}},@{Name="Freespace"; Expression={$_.Freespace/1GB}} | sort -property Freespace | format-table;
$freespace = $obj.diskUsage / $obj.diskCapacity;
$obj | add-member -name FreeSpace -MemberType NoteProperty -Value $freespace;

The error I always get is:

Attempted to divide by zero.
At line:1 char:30
+ $freespace = $obj.diskUsage /  <<<< $obj.diskCapacity;

Sorry to be a pain,

Lee

Thanks Shay, i have just tested the speed of this compared to my first effort and you were right, it's loads faster.

Thanks for the suggestion, I think in future i'll bear this in mind.

Regards

Lee

Sorry Shay, further to my last reply, to get the script to work I had to lose the -path option and then it run real fast.  However, when I just checked the output csv the values for diskspace and freespace were all 0.

Regards

Lee

Sorry Lee, my bad. I pasted an incomplete  wmi query. Here's a modifed version of the complete command (one line):  

gwmi -query "SELECT SystemName,Caption,VolumeName,Size,Freespace FROM win32_logicaldisk WHERE DriveType=3" -computer (gc c:\servers.txt) | Select-Object SystemName,Caption,VolumeName,@{Name="Size(GB)"; Expression={"{0:N2}" -f ($_.Size/1GB)}},@{Name="Freespace(GB)"; Expression={"{0:N2}" -f ($_.Freespace/1GB)}} | export-csv c:\Disk-GB.csv

Add this to your select-object statment, it adds a new column ('% free') to the output

@{n="% Free";e={"{0:P2}" -f ([long]$_.FreeSpace/[long]$_.Size)}}

THank you for the detail. Very nice!  However, my serverlist.txt contains servers that either may not be accessible or are in another domain and not reachable with the credentials that i am logged in with. If the script cannot reach a server, it fails and there is no c:\disk-GB.csv generated. How can i get the scipt to keep going even though the server may not exist or is not reachable? THank you.